Skip to content

Do not override existing keys when using stellar keys add without --overwrite.#2253

Merged
fnando merged 1 commit into
mainfrom
stellar-keys-add-overwrite
Oct 14, 2025
Merged

Do not override existing keys when using stellar keys add without --overwrite.#2253
fnando merged 1 commit into
mainfrom
stellar-keys-add-overwrite

Conversation

@fnando
Copy link
Copy Markdown
Member

@fnando fnando commented Oct 14, 2025

What

Prevent existing keys from being replaced when --overwrite is not provided. This matches the stellar keys generate existing behavior.

Why

Close #2246

Known limitations

N/A

@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Oct 14, 2025
@fnando fnando force-pushed the stellar-keys-add-overwrite branch from dcb5dd3 to 9a07d7c Compare October 14, 2025 16:56
@fnando fnando self-assigned this Oct 14, 2025
@fnando fnando moved this from Backlog (Not Ready) to Needs Review in DevX Oct 14, 2025
@fnando fnando added enhancement New feature or request cli Related to Soroban CLI labels Oct 14, 2025
Copy link
Copy Markdown
Contributor

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👏

Comment thread cmd/crates/soroban-test/tests/it/integration/keys.rs
@fnando fnando enabled auto-merge (squash) October 14, 2025 17:07
@fnando fnando merged commit 197fcc0 into main Oct 14, 2025
28 checks passed
@fnando fnando deleted the stellar-keys-add-overwrite branch October 14, 2025 17:07
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in DevX Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Related to Soroban CLI enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Adding a new key replaces an existing one without confirmation

2 participants